Add list of spare and faulty nodes to PeerList #349
Conversation
| primary: PeerId, | ||
| witnesses: HashSet<PeerId>, |
There was a problem hiding this comment.
witnesses are what is currently called Secondaries in the spec. Will the naming be aligned or is there a particular reason for the difference?
There was a problem hiding this comment.
I picked witnesses to be consistent with the naming in the multi-peer JSON tests, but you are right that we should align them. Let's already merge this and I'll open an issue to track this and to discuss which name we want to keep.
| } | ||
|
|
||
| /// Get a list of references to all the witnesses, | ||
| /// (ie. all peers which are not the primary). | ||
| pub fn witnesses(&self) -> Vec<&Instance> { | ||
| self.peers | ||
| self.instances |
There was a problem hiding this comment.
This method now seems to be wrong as it will return all Instance which are not primary (as per the docs above but not what we want when doing fork detection), therefore we might be returning faulty nodes, and we are going to contact all instances in this peer list. Effectively communicating with all full nodes instead of a subset defined in witnesses. This could probably be fixed in #397 @romac
Neither list are currently used but have been added to match the spec more closely.