CommitSig Serialization refactor #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ializers into module
Co-authored-by: Ismail Khoffi <[email protected]>
greg-szabo
changed the title
Codecov Report
@@ Coverage Diff @@
## greg/serialization-2 #258 +/- ##
======================================================
Coverage ? 27.9%
======================================================
Files ? 102
Lines ? 3656
Branches ? 1160
======================================================
Hits ? 1023
Misses ? 1823
Partials ? 810 Continue to review full report at Codecov.
|
greg-szabo
changed the base branch from
greg/serialization-2
to
greg/serialization-2-alter
melekes
reviewed
May 14, 2020
| return Err("signature is present for BlockIDFlagAbsent CommitSig"); | ||
| } | ||
| Ok(CommitSig::BlockIDFlagAbsent { | ||
| validator_address: value.validator_address, |
There was a problem hiding this comment.
where's validator_address validation?
| @@ -59,8 +60,18 @@ impl lite::Commit for block::signed_header::SignedHeader { | |||
| ); | |||
| } | |||
|
|
|||
| // TODO: this last check is only necessary if we do full verification (2/3) | |||
There was a problem hiding this comment.
No idea, it was in the code from before.
greg-szabo
changed the title
|
Closing in favor of #277 . Anton's notes were carried over too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #247 - serialization refactor CommitSig "blob"
While chopping up PR #248 into multiple smaller PRs, this one that implements the enum-based CommitSig derailed from master so much that it's easier to cherry-pick the commits from this and open a new PR. That's what's going to happen. I'm keeping this open and in draft state until we were able to merge all changes from this into master using these smaller PRs. Then I'll close it.
In this step the CommitSig enum is introduced and the serializers.rs file is moved into its own folder and broken out into multiple files.
Unfortunately I couldn't separate the file move from the implementation of the CimmitSig. (Originally, the steps were 1. interim CommitSig implementation 2. move to folder 3. CommitSig enum implementation and cherry-picking the second step didn't work well without using the first step, but that's not needed any more.)
Converting this into a draft as long as step 2 (#269) is not merged.