Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization improvements #248

Closed
wants to merge 17 commits into from
Closed

Serialization improvements #248

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
43a3a0f
Simplified primitives serializers, moved duration, hex and base64 ser…
greg-szabo May 1, 2020
1d98d7c
Documentation update
greg-szabo May 1, 2020
57bb7da
Serialization test cases fix
greg-szabo May 1, 2020
d2719d4
Added byte array serializer with the option to interpret null as empt…
greg-szabo May 1, 2020
8346e5f
Update documentation on serializers
greg-szabo May 2, 2020
a350696
Refactored CommitSig
greg-szabo May 2, 2020
cf78bd4
Updated CHANGELOG
greg-szabo May 2, 2020
f0bdaaf
Update tendermint/src/block/commit_sig.rs
greg-szabo May 2, 2020
fb93228
Merge branch 'master' into greg/serialization-improvements
greg-szabo May 2, 2020
4c9bcf7
cargo fmt
greg-szabo May 2, 2020
bfe9d7d
Clippy fixes
greg-szabo May 3, 2020
d1b33ff
Restore JSON output for clippy
greg-szabo May 3, 2020
95b5870
Refactor serializers into its own folder
greg-szabo May 4, 2020
b7005cf
Separated CommitSig serialization and validation using serde 'from' a…
greg-szabo May 4, 2020
2a032ab
Rust nightly coverage check fix
greg-szabo May 4, 2020
877df07
temporary fixes to JSON test (#253)
Shivani912 May 5, 2020
5aefc81
Merge branch 'master' into greg/serialization-improvements
greg-szabo May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
args: --all-features --no-fail-fast
env:
CARGO_INCREMENTAL: "0"
RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Zno-landing-pads"
RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=unwind -Zpanic_abort_tests'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fix this on master, get that PR merged in quickly and merge master into this PR? It would benefit all other opened PRs in the meantime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a "one-branch" guy :D
Sure, that makes sense.

- uses: actions-rs/[email protected]
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
Expand Down