Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tendermint: Allow misformed blocks when decoding them from Protobuf or RPC responses #1404

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Mar 28, 2024

Closes: #1403

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 59.3%. Comparing base (99ed0b9) to head (d023a5b).
Report is 2 commits behind head on main.

❗ Current head d023a5b differs from pull request most recent head 027410f. Consider uploading reports for the commit 027410f to get more accurate results

Files Patch % Lines
tendermint/src/block.rs 48.5% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1404     +/-   ##
=======================================
- Coverage   60.1%   59.3%   -0.8%     
=======================================
  Files        271     271             
  Lines      26221   26545    +324     
=======================================
- Hits       15768   15757     -11     
- Misses     10453   10788    +335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac marked this pull request as ready for review April 5, 2024 08:36
@romac romac force-pushed the romac/allow-misformed-block branch from 29dc7a7 to 027410f Compare April 5, 2024 09:29
@romac romac merged commit c45f593 into main Apr 5, 2024
25 checks passed
@romac romac deleted the romac/allow-misformed-block branch April 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot properly parse block
2 participants