rpc: replace hyper::Client with reqwest::Client
#1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hyper, the high-level Client implementation is going to be removed in the next major release. The current client lacks built-in support for HTTP proxies, and we want to ditch hyper-proxy as it is unmaintained and its webpki dependency has known security issues.
Oops, this was temporary and not meant to be commited. The CLI can be used to test the proxy support.
mzabaluev
commented
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #1362 +/- ##
=======================================
- Coverage 60.7% 60.2% -0.6%
=======================================
Files 274 274
Lines 26864 27199 +335
=======================================
+ Hits 16322 16386 +64
- Misses 10542 10813 +271
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
romac
reviewed
Sep 28, 2023
romac
reviewed
Sep 28, 2023
|
Love all that deleted code 🥇 |
Remove ugly turbofish syntax. The changes only affect internal methods, so these stylistics do not matter a lot.
This solves the problem with using type alias as a constructor.
This was referenced Sep 28, 2023
romac
reviewed
Sep 29, 2023
5 tasks
Co-authored-by: Romain Ruetschi <[email protected]>
romac
approved these changes
Sep 29, 2023
SuperFluffy
pushed a commit
to astriaorg/tendermint-rs
that referenced
this pull request
Oct 12, 2023
…1362) * rpc: replace hyper::Client with reqwest::Client In hyper, the high-level Client implementation is going to be removed in the next major release. The current client lacks built-in support for HTTP proxies, and we want to ditch hyper-proxy as it is unmaintained and its webpki dependency has known security issues. * Remove the proxy_client example Oops, this was temporary and not meant to be commited. The CLI can be used to test the proxy support. * Bump async-tungstenite version to 0.23 * rpc: fix proxy configuration in http::Builder * rpc: use argument type to select the dialog Remove ugly turbofish syntax. The changes only affect internal methods, so these stylistics do not matter a lot. * rpc: restore LatestDialog as re-export This solves the problem with using type alias as a constructor. * Changelog entries for informalsystems#1362 * rpc: prune dependencies for http-client feature * rpc: demote http to dev-dependencies * Small rewording in changelog for informalsystems#1342 (informalsystems#1362) Co-authored-by: Romain Ruetschi <[email protected]> --------- Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1342
In
hyper, the high-levelClientimplementation is going to be removed in the next major release. The current client lacks built-in support for HTTP proxies, and we want to ditchhyper-proxyas it is unmaintained and itswebpkidependency has a known security issue..changelog/