Update to bytes 0.5 and amino_rs 0.5 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Jan 19, 2020
| @@ -26,6 +26,7 @@ extern crate prost_amino as prost; | |||
| #[allow(unused_extern_crates)] | |||
| #[macro_use] | |||
| extern crate prost_amino_derive as prost_derive; | |||
| extern crate bytes; | |||
There was a problem hiding this comment.
Are either of these extern crates still needed? I know prost was looking directly in the sysroot for them before which precluded renaming them any other way than through the extern crate directive, but if everything is namespaced correctly, it seems like it should be possible to get rid of them?
tarcieri
approved these changes
Jan 19, 2020
|
I assume this was tested locally, as well as running clippy on it? CircleCi doesn't run on forks :-/ |
Merged
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to bytes_0.5 and amino_rs 0.5 and makes all the amino_rs tokens independent of prost tokens enabling prost and amino_rs to be combined in a dependency.