-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light-client-js: remove the syn version pin #1242
Conversation
The bug this used to work around is closed and the problem no longer seems to persist.
Codecov Report
@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
- Coverage 64.4% 64.4% -0.1%
=======================================
Files 245 245
Lines 21485 21489 +4
=======================================
Hits 13842 13842
- Misses 7643 7647 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
To remove deprecation warnings and do the right thing, use serde-wasm-bindgen utilities for serializing and deserializing Rust types to and from JsValue.
Accept also signed integers as these are produced from JSON by serde-wasm-bindgen.
Now that deserialization likes to take ownership of our JS values, it does not make sense to pass them by reference from JavaScript only to clone them immediately. This is not a breaking change for the JavaScript API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would this be considered a breaking change, given the dependency update?
I don't think so. A wasm bundle has all its Rust dependencies baked in, and the JavaScript signature of the entry point did not change either. That said, I need to give it a suitable changelog entry. |
The bug this used to work around is closed and the problem
no longer seems to persist.