Refactor Condition into a struct with its key and an Operation enum
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## romac/pub-query-conditions #1231 +/- ##
============================================================
Coverage ? 64.3%
============================================================
Files ? 244
Lines ? 21393
Branches ? 0
============================================================
Hits ? 13758
Misses ? 7635
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thanethomson
approved these changes
Nov 16, 2022
thanethomson
added a commit
that referenced
this pull request
Nov 16, 2022
* Make `Query` fields public * Add `Condition::key` method * Add changelog entry * Update .changelog/unreleased/improvements/1230-query-api.md Co-authored-by: Thane Thomson <[email protected]> * Refactor `Condition` into a struct with its key and an `Operation` enum (#1231) Co-authored-by: Thane Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.