Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump async-tungstenite to 0.17 #1166

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Bump async-tungstenite to 0.17 #1166

merged 3 commits into from
Jul 27, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Jul 27, 2022 •
edited
Loading

Fixes: #1165

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@mzabaluev
Copy link
Contributor Author

I'd like some pointers on how to test IPv6 loopback in CI. Should rpc-probe be used?

@mzabaluev mzabaluev added the dependencies Pull requests that update a dependency file label Jul 27, 2022
@mzabaluev mzabaluev marked this pull request as ready for review July 27, 2022 14:07
mzabaluev added a commit that referenced this pull request Jul 27, 2022
@mzabaluev
Changelog entry for #1166
9be9976
@mzabaluev mzabaluev added the rpc label Jul 27, 2022
@mzabaluev mzabaluev mentioned this pull request Jul 27, 2022
Merged
@codecov-commenter
Copy link

Codecov Report

Merging #1166 (cf4549a) into master (ab896a6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1166   +/-   ##
======================================
  Coverage    64.6%   64.6%           
======================================
  Files         232     232           
  Lines       15667   15667           
======================================
  Hits        10136   10136           
  Misses       5531    5531

Help us with your feedback. Take ten seconds to tell us how you rate us.

@thanethomson thanethomson merged commit 3f63430 into master Jul 27, 2022
@thanethomson thanethomson deleted the mikhail/bump-tungstenite branch July 27, 2022 14:30
thanethomson pushed a commit that referenced this pull request Jul 27, 2022
@mzabaluev
Bump async-tungstenite to 0.17 (#1167)
2426a65 
* Bump async-tungstenite to 0.17

* rpc-probe: Bump async-tungstenite version to 0.17

* Changelog entry for #1166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

@soareschen soareschen Awaiting requested review from soareschen

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async-tungstenite version too old
3 participants
@mzabaluev @codecov-commenter @thanethomson