-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out verifier parts of tendermint-light-client
to tendermint-light-client-verifier
#1071
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
========================================
+ Coverage 62.7% 64.6% +1.9%
========================================
Files 236 238 +2
Lines 21192 20571 -621
========================================
+ Hits 13296 13307 +11
+ Misses 7896 7264 -632
Continue to review full report at Codecov.
|
…ht-client-verifier
12077c4
to
3c4c958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've submitted #1074 with some recommendations - what do you think?
If they make sense, I can do the same for your other PR tomorrow to backport those changes to v0.23.x.
…light-client` (#1074) * Re-export tendermint_light_client_verifier as verifier from tendermint_light_client Signed-off-by: Thane Thomson <[email protected]> * Remove unnecessary tendermint-light-client import Signed-off-by: Thane Thomson <[email protected]> * Fix crate docs to reflect verifier extraction Signed-off-by: Thane Thomson <[email protected]> * Add changelog entry Signed-off-by: Thane Thomson <[email protected]>
Looks good. Thanks! I have also added re-export to the original paths that are exported by the |
Fixes #1027.
.changelog/