Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary cdylib artifacts from the build #1052

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Remove unnecessary cdylib artifacts from the build #1052

merged 2 commits into from
Dec 13, 2021

Conversation

mzabaluev
Copy link
Contributor

Closes #1051

@mzabaluev mzabaluev added code-quality Issues relating to linting configuration and general code quality enhancement New feature or request light-client Issues/features which involve the light client labels Dec 10, 2021
@mzabaluev mzabaluev requested a review from romac December 10, 2021 15:25
thanethomson
thanethomson approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all builds without any problems, so I'm happy 🙂

@thanethomson thanethomson merged commit 8aa91c3 into master Dec 13, 2021
@thanethomson thanethomson deleted the mikhail/no-useless-cdylibs branch December 13, 2021 16:59
@thanethomson
Copy link
Contributor

@mzabaluev would you like this change for the v0.23.x series too?

@mzabaluev
Copy link
Contributor Author

It's non-essential (nothing breaks due to the bogus cdylibs), but trivial enough to merge. Up to you.

thanethomson pushed a commit that referenced this pull request Dec 13, 2021
@mzabaluev @thanethomson
Remove unnecessary cdylib artifacts from the build (#1052)
6dd12e8 
* Remove unnecessary cdylib artifacts from the build

* Purge redundant [lib] sections from Cargo.toml

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson thanethomson mentioned this pull request Dec 13, 2021
Merged
thanethomson added a commit that referenced this pull request Dec 13, 2021
@thanethomson @mzabaluev
Remove unnecessary cdylib artifacts from the build (#1052) (#1056)
c31d8cb 
* Remove unnecessary cdylib artifacts from the build

* Purge redundant [lib] sections from Cargo.toml

Signed-off-by: Thane Thomson <[email protected]>

Co-authored-by: Mikhail Zabaluev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
code-quality Issues relating to linting configuration and general code quality enhancement New feature or request light-client Issues/features which involve the light client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary cdylib targets are built
2 participants
@mzabaluev @thanethomson