Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR: Time API improvements #1035

Merged
merged 1 commit into from
Dec 7, 2021
Merged

ADR: Time API improvements #1035

merged 1 commit into from
Dec 7, 2021

Conversation

mzabaluev
Copy link
Contributor

Proposes changes to time API in tendermint and some related improvements that would be good to do in a tranche of breaking changes.

@mzabaluev mzabaluev added enhancement New feature or request breaking technical debt Issues that are important, but not urgent, that should eventually receive attention domain-types Anything relating to the creation, modification or removal of domain types labels Nov 29, 2021
@mzabaluev mzabaluev mentioned this pull request Nov 29, 2021
Open
thanethomson
thanethomson approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Well-reasoned, I'd say. We can revisit the time issue again once the Rust ecosystem's figured out a more coherent strategy for handling time safely/soundly.

@thanethomson thanethomson merged commit 9b6bd82 into master Dec 7, 2021
@thanethomson thanethomson deleted the mikhail/adr/time-api-cleanup branch December 7, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
breaking domain-types Anything relating to the creation, modification or removal of domain types enhancement New feature or request technical debt Issues that are important, but not urgent, that should eventually receive attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzabaluev @thanethomson