Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization of RPC endpoint /abci_info fails with recent revisions of gaiad #1132

Closed
mzabaluev opened this issue May 24, 2022 · 0 comments · Fixed by #1131
Closed

Deserialization of RPC endpoint /abci_info fails with recent revisions of gaiad #1132

mzabaluev opened this issue May 24, 2022 · 0 comments · Fixed by #1131
Labels
bug Something isn't working

Comments

@mzabaluev
Copy link
Contributor

Version(s) of tendermint-rs: v0.24.0-pre.2

tendermint-rpc fails to parse the /abci_info response of gaiad in latest revisions from the gaia main branch.
Here is the relevant part of the error dump.

2: serde parse error
3: missing field `app_version` at line 10 column 5

The corresponding JSON serialization for the structure's fields in tendermint-go is annotated with the "omitempty" flag,
which likely causes the value to be omitted when the Go implementation considers it "empty". I have observed via a TCP dump that the app_version field is not present in the object.

Steps to reproduce

Encountered while trying to run integration tests for informalsystems/hermes#2213 with gaiad revision 67fbb896bfc46c32d4395892b149857fe27a7572

Definition of "done"

Allow all the fields in the JSON-RPC object to be absent, falling back to default values in the serde implementation for the corresponding tendermint-rpc data structure.

@mzabaluev mzabaluev added the bug Something isn't working label May 24, 2022
@mzabaluev mzabaluev changed the title RPC Deserialization of RPC endpoint /abci_info fails with recent revisions of gaiad May 24, 2022
mzabaluev added a commit to informalsystems/hermes that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant