Fix new Clippy warnings introduced in Rust 1.68 (#1284)

config/src/config.rs

@@ -611,7 +611,7 @@ pub struct TxIndexConfig {
 }
 
 /// What indexer to use for transactions
-#[derive(Copy, Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
+#[derive(Copy, Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize, Default)]
 pub enum TxIndexer {
     /// "null"
     // TODO(tarcieri): use an `Option` type here?
@@ -621,15 +621,10 @@ pub enum TxIndexer {
     /// "kv" (default) - the simplest possible indexer, backed by key-value storage (defaults to
     /// levelDB; see DBBackend).
     #[serde(rename = "kv")]
+    #[default]
     Kv,
 }
 
-impl Default for TxIndexer {
-    fn default() -> TxIndexer {
-        TxIndexer::Kv
-    }
-}
-
 /// instrumentation configuration options
 #[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Eq)]
 pub struct InstrumentationConfig {

tendermint/src/abci/code.rs

@@ -12,21 +12,16 @@ use serde::{
 /// <https://tendermint.com/docs/spec/abci/abci.html#errors>
 ///
 /// Note that in the future there may potentially be non-zero success codes.
-#[derive(Copy, Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
+#[derive(Copy, Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord, Default)]
 pub enum Code {
     /// Success
+    #[default]
     Ok,
 
     /// Error codes
     Err(NonZeroU32),
 }
 
-impl Default for Code {
-    fn default() -> Code {
-        Code::Ok
-    }
-}
-
 impl Code {
     /// Was the response OK?
     pub fn is_ok(self) -> bool {

tendermint/src/abci/request/check_tx.rs

@@ -22,19 +22,15 @@ pub struct CheckTx {
 /// to avoid confusion with Rust types.
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
 #[repr(i32)]
+#[derive(Default)]
 pub enum CheckTxKind {
     /// A full check is required (the default).
+    #[default]
     New = 0,
     /// Indicates that the mempool is initiating a recheck of the transaction.
     Recheck = 1,
 }
 
-impl Default for CheckTxKind {
-    fn default() -> Self {
-        CheckTxKind::New
-    }
-}
-
 // =============================================================================
 // Protobuf conversions
 // =============================================================================

tendermint/src/abci/response/process_proposal.rs

@@ -3,19 +3,14 @@ use crate::prelude::*;
 #[doc = include_str!("../doc/response-processproposal.md")]
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[repr(i32)]
+#[derive(Default)]
 pub enum ProcessProposal {
+    #[default]
     Unknown = 0,
     Accept = 1,
     Reject = 2,
 }
 
-impl Default for ProcessProposal {
-    #[inline]
-    fn default() -> Self {
-        ProcessProposal::Unknown
-    }
-}
-
 // =============================================================================
 // Protobuf conversions
 // =============================================================================

tendermint/src/hash.rs

@@ -24,11 +24,12 @@ pub enum Algorithm {
 }
 
 /// Hash digests
-#[derive(Copy, Clone, Hash, Eq, PartialEq, PartialOrd, Ord)]
+#[derive(Copy, Clone, Hash, Eq, PartialEq, PartialOrd, Ord, Default)]
 pub enum Hash {
     /// SHA-256 hashes
     Sha256([u8; SHA256_HASH_SIZE]),
     /// Empty hash
+    #[default]
     None,
 }
 
@@ -144,12 +145,6 @@ impl Debug for Hash {
     }
 }
 
-impl Default for Hash {
-    fn default() -> Self {
-        Hash::None
-    }
-}
-
 impl Display for Hash {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let hex = match self {

tendermint/src/node/id.rs

@@ -15,7 +15,7 @@ use crate::{error::Error, prelude::*};
 pub const LENGTH: usize = 20;
 
 /// Node IDs
-#[allow(clippy::derive_hash_xor_eq)]
+#[allow(clippy::derived_hash_with_manual_eq)]
 #[derive(Copy, Clone, Eq, Hash, PartialOrd, Ord)]
 pub struct Id([u8; LENGTH]);
 

tendermint/src/node/info.rs

@@ -82,23 +82,18 @@ pub struct OtherInfo {
 }
 
 /// Transaction index status
-#[derive(Copy, Clone, Debug, Deserialize, Eq, PartialEq, Serialize)]
+#[derive(Copy, Clone, Debug, Deserialize, Eq, PartialEq, Serialize, Default)]
 pub enum TxIndexStatus {
     /// Index is on
     #[serde(rename = "on")]
+    #[default]
     On,
 
     /// Index is off
     #[serde(rename = "off")]
     Off,
 }
 
-impl Default for TxIndexStatus {
-    fn default() -> TxIndexStatus {
-        TxIndexStatus::On
-    }
-}
-
 impl From<TxIndexStatus> for bool {
     fn from(status: TxIndexStatus) -> bool {
         match status {