fix: immut over mut ref on validate #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 71.49% 71.48% -0.01%
==========================================
Files 125 125
Lines 15149 15145 -4
==========================================
- Hits 10831 10827 -4
Misses 4318 4318
☔ View full report in Codecov by Sentry. |
|
Can you add a changelog that refers to this PR? |
Farhad-Shabani
approved these changes
Sep 13, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* immut over mut ref on validate * cargo fmt * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #864
Description
The core validate handler uses mutable reference, even though, the mutable reference is not needed.
https://github.com/cosmos/ibc-rs/blob/133863db5f9ce56d57b2502913a21bde0fad7bda/crates/ibc/src/core/handler.rs#L54-L58
This PR updates it to immutable reference.
https://github.com/cosmos/ibc-rs/blob/99ca41047f8f7ddfd16c955fc340ebf969a641d4/crates/ibc/src/core/handler.rs#L54-L58
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.