Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testkit): add store implementations in ibc-testkit #1048

Closed
wants to merge 9 commits into from

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Jan 19, 2024

Closes: #1045

Description

This PR includes basecoin-store crate from basecoin repo inside ibc-testkit. These store implementations are only intended for testing purposes.

We plan to use these implementations to improve the coverage of our IBC tests.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from Farhad-Shabani January 19, 2024 13:51
@rnbguy rnbguy self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 437 lines in your changes are missing coverage. Please review.

Comparison is base (ee92645) 71.30% compared to head (89a0b11) 70.34%.

Files Patch % Lines
ibc-testkit/store/src/impls/growing.rs 0.00% 73 Missing ⚠️
ibc-testkit/store/src/impls/in_memory.rs 0.00% 64 Missing ⚠️
ibc-testkit/store/src/impls/revertible.rs 0.00% 60 Missing ⚠️
ibc-testkit/store/src/impls/shared.rs 0.00% 46 Missing ⚠️
ibc-testkit/store/src/types/store.rs 0.00% 35 Missing ⚠️
ibc-testkit/store/src/utils/codec.rs 0.00% 35 Missing ⚠️
ibc-testkit/store/src/types/path.rs 33.33% 28 Missing ⚠️
ibc-testkit/store/src/avl/tree.rs 87.58% 19 Missing ⚠️
ibc-testkit/store/src/avl/node.rs 82.92% 14 Missing ⚠️
ibc-testkit/store/src/avl/as_bytes.rs 43.47% 13 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   71.30%   70.34%   -0.96%     
==========================================
  Files         187      204      +17     
  Lines       18507    19382     +875     
==========================================
+ Hits        13196    13634     +438     
- Misses       5311     5748     +437     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy marked this pull request as draft January 26, 2024 12:19
@rnbguy
Copy link
Member Author

rnbguy commented Feb 2, 2024

@Farhad-Shabani maybe we close this PR without merging ? we decided to use basecoin-store as a remote dependency.

@rnbguy rnbguy deleted the rano/testkit/store branch April 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imp(testkit): adopt basecoin-store in ibc-testkit
2 participants