Introduce 'create connection' cmd #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=========================================
+ Coverage 13.6% 43.5% +29.9%
=========================================
Files 69 152 +83
Lines 3752 9908 +6156
Branches 1374 0 -1374
=========================================
+ Hits 513 4318 +3805
- Misses 2618 5590 +2972
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
adizere
changed the title
adizere
commented
Feb 25, 2021
ancazamfir
reviewed
Feb 26, 2021
romac
reviewed
Feb 26, 2021
Co-authored-by: Romain Ruetschi <[email protected]>
ancazamfir
approved these changes
Feb 26, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Partial implementation of 'create connection' cmd * More slick approach for exiting the program. * Picking up work on this * Split create connection into the two basic sub-cases * Refactored create_reusing_clients * Fixed handshake with delay period option. * Typos, finishd impl for create_reusing_clients * Aligned with ADR 006 * Changelog * Refactored cli_utils. Improved error output. * More decent doc for Unrecoverable * fmt fix * review based on Anca's suggestions * Removed delay option. * Update relayer-cli/src/conclude.rs Co-authored-by: Romain Ruetschi <[email protected]> * rm Unrecoverable, replaced with unreachable Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #630
Description
Adds a new command:
Optional:
[--delay <delay>]Optional:
[--delay <delay>][X] the(this was a bug in modues, fixed it in 8b00730)--delayparameter is not supported (gaia v0.4.0 throws error at open try step). we should disable this option.startcommand. Will align output with ADR006 and requirements from Agoric's dynamic IBC use case #628 in separate work.For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.