Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel close init and confirm CLIs #556

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Add channel close init and confirm CLIs #556

merged 4 commits into from
Jan 27, 2021

Conversation

ancazamfir
Copy link
Collaborator

Closes: informalsystems/ibc-rs#94

Description

Implements close CLIs. Note that testing these require custom gaia image as described in https://github.com/informalsystems/ibc-rs/blob/anca/chan_close/relayer-cli/relayer_operation_instructions.md


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir ancazamfir requested review from romac and adizere January 26, 2021 16:43
@ancazamfir ancazamfir self-assigned this Jan 26, 2021
@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #556 (ca6a277) into master (b1b37f5) will increase coverage by 32.6%.
The diff coverage is 67.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#556      +/-   ##
=========================================
+ Coverage    13.6%   46.3%   +32.6%     
=========================================
  Files          69     138      +69     
  Lines        3752    9172    +5420     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4251    +3738     
- Misses       2618    4921    +2303     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 100.0% <ø> (+66.6%) ⬆️
modules/src/ics03_connection/msgs/conn_open_try.rs 86.7% <ø> (ø)
modules/src/ics03_connection/version.rs 97.6% <ø> (ø)
modules/src/ics04_channel/channel.rs 77.2% <ø> (+62.1%) ⬆️
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c0e6d...ca6a277. Read the comment docs.

@ancazamfir ancazamfir merged commit 8c54128 into master Jan 27, 2021
@ancazamfir ancazamfir deleted the anca/chan_close branch January 27, 2021 11:02
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Add channel close init and confirm CLIs

* Update Changelog

* Fixed typos in operating instructions.

Co-authored-by: Adi Seredinschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants