-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Client queries after last protobuf updates #309
Conversation
Tested the client queries manually.
|
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#309 +/- ##
=========================================
+ Coverage 13.6% 37.5% +23.8%
=========================================
Files 69 124 +55
Lines 3752 7993 +4241
Branches 1374 2770 +1396
=========================================
+ Hits 513 3001 +2488
- Misses 2618 4753 +2135
+ Partials 621 239 -382
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the last changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments & remarks. Looks ready!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have one question inline below.
* fix type-urls, introduce constants * Remove client_type from MsgCreateAnyClient, initial cleanup of tests and mock context * cleanup * Remove some unwraps * Adi's review comments
Closes: cosmos/ibc-rs#106
Description
Fixes the
type-url
s to be consistent with latest protos which are used in stargate-4.Added constants for the client related URLs. These may change with fix for #254
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer