ADR011 light client extraction (first iteration) #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Chen <[email protected]>
…hub.com/informalsystems/ibc-rs into hu55a1n1/adr011-light-client-extraction
…ht-client-extraction
…ht-client-extraction-iter-1
romac
approved these changes
Jul 21, 2022
6 tasks
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Initial draft * Add object-safety related decisions * More on object-safety * Document proposal on downcasting support * Special case AnyClient removal * Ideas on splitting work * Summarize rationale for Any* enums described in ADR003 * Address review feedback * Apply suggestions from code review Co-authored-by: Sean Chen <[email protected]> * Add section on light client registry * Long-lived branch * Add section on domain types * Proposal for handling light client specific code * ADR table entry * Add examples for light client specific module code * Move `ClientState::client_def()` to `ClientReader::client_def()` * Modify example describing need for client registry * Add proposal to merge `ClientDef` into `ClientState` * Add line about client registry reexporting concrete types * Add .changelog entry * Fix changelog links * Add comments about object safe Protobuf trait * Delete old comment regarding `Header::encode_any()` Co-authored-by: Sean Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @romac, this is the first iteration of ADR011 that there seems to be an agreement upon and something we can merge right away. The original PR (#2356) will remain open so that we can improve it iteratively.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.