Fix bug in wildcard filter where pattern would match in the middle of a string #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a string The fix anchors the regex by delimiting it with `^` and `$` so that it only matches the full string and not anywhere in the middle.
hu55a1n1
approved these changes
Apr 7, 2022
|
|
||
| impl Wildcard { | ||
| pub fn new(pattern: String) -> Result<Self, regex::Error> { | ||
| let escaped = regex::escape(&pattern).replace("\\*", "(?:.*)"); | ||
| let regex = format!("^{escaped}$").parse()?; |
There was a problem hiding this comment.
Nice use of captured identifiers! 💯
| @@ -137,28 +137,35 @@ impl Serialize for ChannelFilters { | |||
|
|
|||
| /// Newtype wrapper for expressing wildcard patterns compiled to a [`regex::Regex`]. | |||
| #[derive(Clone, Debug)] | |||
| pub struct Wildcard(regex::Regex); | |||
| pub struct Wildcard { | |||
| pattern: String, | |||
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
… a string (informalsystems#2076) * Fix bug in wildcard filter where pattern would match in the middle of a string The fix anchors the regex by delimiting it with `^` and `$` so that it only matches the full string and not anywhere in the middle. * Add changelog entry * Store original pattern inside `Wildcard` instead of re-deriving it from the regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2075
Description
The fix anchors the regex by delimiting it with
^and$so that it only matches the full string and not anywhere in the middle.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.