Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric for query cache hits #2006

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Add metric for query cache hits #2006

merged 7 commits into from
Mar 30, 2022

Conversation

romac
Copy link
Member

@romac romac commented Mar 23, 2022 •
edited
Loading

Closes: #2036

  • Add a query_cache_hits metric, indexed by chain and query type.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac force-pushed the romac/cache-hit-metrics branch from 53f2ff6 to d774001 Compare March 23, 2022 17:04
@romac romac force-pushed the romac/cache-hit-metrics branch from d774001 to a27ad1a Compare March 23, 2022 17:57
@romac romac marked this pull request as ready for review March 25, 2022 08:00
adizere
adizere reviewed Mar 25, 2022
View reviewed changes
relayer/src/cache.rs Show resolved Hide resolved
relayer/src/chain/handle/cache.rs Show resolved Hide resolved
@adizere adizere self-assigned this Mar 29, 2022
@adizere adizere linked an issue Mar 30, 2022 that may be closed by this pull request
Add metric for query cache hits #2036
Closed
@adizere adizere merged commit ed42637 into master Mar 30, 2022
@adizere adizere deleted the romac/cache-hit-metrics branch March 30, 2022 09:32
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac @adizere
Add metric for query cache hits (informalsystems#2006)
93a8085 
* Add metric for query cache hits

* Use built-in library for showing metrics

* Cleanup

* Typo fix

* unclog

* Update changelog entry

Co-authored-by: Adi Seredinschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metric for query cache hits
2 participants
@romac @adizere