Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable color log on integration test CI #2002

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Disable color log on integration test CI #2002

merged 1 commit into from
Mar 23, 2022

Conversation

soareschen
Copy link
Contributor

Description

Adds a NO_COLOR_LOG variable that if is set to 1, will disable eyre_color when running the integration tests. This will help inspecting the log output from CI.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen merged commit 06cff57 into master Mar 23, 2022
@soareschen soareschen deleted the soares/ci-no-color-log branch March 23, 2022 12:48
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen
Disable color log on CI (informalsystems#2002)
6aa6585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soareschen @romac