Disable config reload and throw a warning on receiving SIGHUP #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanchen1991
requested review from
adizere,
ancazamfir and
romac
as code owners
|
LGTM modulo a nitpick. I'll take care of removing the config reload code in a follow-up PR. |
romac
approved these changes
Feb 18, 2022
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…alsystems#1894) * Disable config reload and throw a warning on receiving SIGHUP * Change from `info` to `warning` level and add changelog entry * Remove `ConfigReload` param from `register_signals` * Update relayer-cli/src/commands/start.rs Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1885
Description
Disables configuration reloading upon receiving a SIGHUP signal and throws a warning notifying the user of this fact and that the feature will be deprecated in the future.
When a SIGHUP signal is sent to Hermes, the logs now look like this
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.