-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.57 and instruct clippy to lint against this version #1660
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
faac6ee
Bump rust-version to 1.57 in Cargo.toml
mzabaluev 14c2b57
Add clippy.toml with the MSRV configuration
mzabaluev 0b420e4
Updated all mentions of MSRV to 1.57
mzabaluev 3776bfc
Changelog entry for #1660
mzabaluev 2c78d22
Add an issue template with Rust update checklist
mzabaluev 594d863
Advise on fixing lints in rust-update template
mzabaluev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Update MSRV to Rust 1.57 | ||
([#1660](https://github.com/informalsystems/ibc-rs/issues/1660)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
name: Rust version update | ||
about: A checklist to perform to update to a new version of Rust. | ||
--- | ||
|
||
# Update to Rust release 1.x.y | ||
|
||
🦀 | ||
|
||
- [ ] Update the version in `rust-toolchain.toml`. | ||
- [ ] Run `cargo clippy --all-features --fix`, review and commit the automatic | ||
fixes, and fix all reported lints. Try to resolve the root causes for | ||
the lints rather than silencing them with `#[allow(...)]`. | ||
|
||
## Update the MSRV (optional) | ||
|
||
Additional steps to perform in order to make the new minimal supported | ||
Rust version: | ||
|
||
- [ ] Update the `rust-version` fields in all `Cargo.toml` files. | ||
- [ ] Update the `msrv` field in `clippy.toml` and fix all lints reported by | ||
`cargo clippy --all-features`. | ||
- [ ] Update the MSRV shields in README files: | ||
- `README.md` | ||
- `relayer-rest/README.md` | ||
- [ ] Update the MSRV in the guide: `guide/src/pre_requisites.md` | ||
- [ ] Add a `.changelog` entry to the `breaking-changes` section, | ||
announcing the new MSRV. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
msrv = "1.57.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ readme = "README.md" | |
keywords = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"] | ||
repository = "https://github.com/informalsystems/ibc-rs" | ||
authors = ["Informal Systems <[email protected]>"] | ||
rust-version = "1.56" | ||
rust-version = "1.57" | ||
description = """ | ||
Implementation of the Inter-Blockchain Communication Protocol (IBC). | ||
This crate comprises the main data structures and on-chain logic. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ version = "0.2.0" | |
authors = ["Informal Systems <[email protected]>"] | ||
edition = "2021" | ||
publish = false | ||
rust-version = "1.56" | ||
rust-version = "1.57" | ||
|
||
[dependencies] | ||
git2 = "0.13" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ keywords = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"] | |
homepage = "https://hermes.informal.systems/" | ||
repository = "https://github.com/informalsystems/ibc-rs" | ||
authors = ["Informal Systems <[email protected]>"] | ||
rust-version = "1.56" | ||
rust-version = "1.57" | ||
description = """ | ||
Hermes is an IBC Relayer written in Rust | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ readme = "README.md" | |
keywords = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"] | ||
repository = "https://github.com/informalsystems/ibc-rs" | ||
authors = ["Informal Systems <[email protected]>"] | ||
rust-version = "1.56" | ||
rust-version = "1.57" | ||
description = """ | ||
Implementation of an IBC Relayer in Rust, as a library | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ readme = "README.md" | |
keywords = ["cosmos", "ibc", "relayer", "telemetry"] | ||
repository = "https://github.com/informalsystems/ibc-rs" | ||
authors = ["Informal Systems <[email protected]>"] | ||
rust-version = "1.56" | ||
rust-version = "1.57" | ||
description = """ | ||
Telemetry service for the Hermes IBC relayer | ||
""" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯