Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation and minor update for flex-error update #1237

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Documentation and minor update for flex-error update #1237

merged 3 commits into from
Jul 27, 2021

Conversation

soareschen
Copy link
Contributor

Description

This is a minor follow up for #988, as it was merged while I was making these changes.

  • Add ADR to describe the decisions of switching to flex-error.
  • Add changelog
  • Address previous review comment to remove some recursive error constructors.

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac merged commit 4b53d77 into master Jul 27, 2021
@romac romac deleted the soares/flex-error-docs branch July 27, 2021 11:06
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen
Documentation and minor update for flex-error update (informalsystems…
af1b480 
…#1237)

* Add ADR to document decisions to use flex-error

* Add changelog for using flex-error

* Remove some recursive error constructors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soareschen @romac