Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes config 0.4 compatibility #1040

Merged
merged 2 commits into from
Jun 3, 2021
Merged

hermes config 0.4 compatibility #1040

merged 2 commits into from
Jun 3, 2021

Conversation

greg-szabo
Copy link
Member

Closes: #1039

Description

gm creates hermes 0.4 (master) compatible configuration


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@greg-szabo greg-szabo requested a review from adizere June 2, 2021 18:28
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two further improvements I can see:

  • Update the .toml file used in example section of the readme.md. Maybe to reduce the amount of config information that needs to be maintained, instead of using a dedicated .toml file in that example, use the default one scripts/gm/gm.toml.

  • The command gm hermes config should ideally not overwrite Hermes's current values in its configuration file, in particular for fields strategy and log_level. I think gm v0.02 was correctly loading the config values and did not overwrite these fields, but these changes in v0.0.3 introduced the overwriting issue.

But these are both minor feature requests, not a priority, so let's leave them for subsequent PRs.

@adizere adizere merged commit 39c7ecd into master Jun 3, 2021
@adizere adizere deleted the greg/gm-hermes-0.4 branch June 3, 2021 07:51
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* hermes config 0.4 compatibility

* hermes telemtry host added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gm: create hermes 0.4-compatible configuration
2 participants