Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memo field #1433

Closed
3 of 6 tasks
Tracked by #1418
adizere opened this issue Oct 7, 2021 · 0 comments · Fixed by #1434
Closed
3 of 6 tasks
Tracked by #1418

Add memo field #1433

adizere opened this issue Oct 7, 2021 · 0 comments · Fixed by #1434
Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@adizere
Copy link
Member

adizere commented Oct 7, 2021

Crate

ibc-relayer-cli

Summary

We'd like to allow the parametrization of the memo for transactions that Hermes submits.

Proposal

There should be two parts to this memo:

  1. a user-configurable part of the memo, e.g., "relayed by operator X"

    • this will serve as a prefix to the overall memo field
    • should be parametrizable on a per-chain basis from the config.toml
    • consider a domain-type validation to hard-limit the allowed length of this field, probably 100 chars
  2. a fixed string representing the Hermes build version plus a link to https://hermes.informal.systems

An example of a memo would be this:

relayed by operator x | Hermes v0.7.3 https://hermes.informal.systems

Acceptance Criteria

  • the memo field in tx submitted by Hermes reflects the user-configurable prefix as well as the Hermes version and website

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the O: usability Objective: cause to improve the user experience (UX) and ease using the product label Oct 7, 2021
@adizere adizere added this to the 10.2021 milestone Oct 7, 2021
adizere added a commit that referenced this issue Oct 7, 2021
@adizere adizere mentioned this issue Oct 7, 2021
5 tasks
adizere added a commit that referenced this issue Oct 12, 2021
* Added initial support for feature #1433

* Comment for Memo type

* Derive Default and add Display instance for Memo

* Use Memo type directly

* Documented the memo prefix

Co-authored-by: Romain Ruetschi <[email protected]>
adizere added a commit that referenced this issue Oct 19, 2021
* Update compat to check IBC-go dependency

* Updated ibc-go vers to match the ibc-go repo releases

* Added lost changelog entry for issue #1433

* Lower log level of health check to warning

* Relax compatibility check from patch version to minor version

* Relax compat versions to `>=0.41, <0.45` for SDK and `>=1.1, <1.2` for IBC-Go

* Add .changelog entry

* Comment fix

Co-authored-by: Romain Ruetschi <[email protected]>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
* Added initial support for feature informalsystems#1433

* Comment for Memo type

* Derive Default and add Display instance for Memo

* Use Memo type directly

* Documented the memo prefix

Co-authored-by: Romain Ruetschi <[email protected]>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
…ms#1431)

* Update compat to check IBC-go dependency

* Updated ibc-go vers to match the ibc-go repo releases

* Added lost changelog entry for issue informalsystems#1433

* Lower log level of health check to warning

* Relax compatibility check from patch version to minor version

* Relax compat versions to `>=0.41, <0.45` for SDK and `>=1.1, <1.2` for IBC-Go

* Add .changelog entry

* Comment fix

Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant