Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist changes from successful transactions #163

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Persist changes from successful transactions #163

merged 3 commits into from
Apr 26, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Feb 22, 2024

Closes #162

@rnbguy rnbguy requested a review from seanchen1991 April 25, 2024 13:46
seanchen1991
seanchen1991 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on this; looks good to me. Just one question for my own understanding, but this is good to merge 👍

basecoin/app/src/abci/v0_37/impls.rs Show resolved Hide resolved
@seanchen1991 seanchen1991 merged commit 6697611 into main Apr 26, 2024
9 checks passed
@seanchen1991 seanchen1991 deleted the rano/store/apply-after-tx branch April 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deliver_tx can revert the previous successful txs
2 participants
@rnbguy @seanchen1991