Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compile chain binary from remote #112

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Aug 29, 2022

Closes #111

Example usage,

atomkraft init transfer
cd transfer
atomkraft chain remote gh:cosmos/cosmos-sdk --ref v0.45.8
...
atomkraft test trace ...

@rnbguy rnbguy added the enhancement New feature or request label Aug 29, 2022
@rnbguy rnbguy self-assigned this Aug 29, 2022
Copy link
Contributor

@andrey-kuprianov andrey-kuprianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in #98, I have essentially the same comments.

  • It is unclear at all whether this feature is needed by our users. We should first discuss with the users, and with our PO (@tesnimab), whether this is needed.
    • I suppose that actually most of our users simply will want to use some binary that is already present on their machines (dev version, not yet released on the main repo)
  • I can imagine lots of situations when it won't work at all:
    • if the project is compiled not using make build (e.g. some custom build process)
    • if there are multiple executables produced
  • The implementation is rushed, and I suppose there are cases where it will work not as expected
    • e.g. , I am not particularly fond of including things like glob("*/*") into our codebase. It may have many unforeseen consequences

Besides, we are in the feature freeze now, before the prototype release, so no new features should be added. Please postpone working on that till the prototype release.

@rnbguy
Copy link
Member Author

rnbguy commented Aug 30, 2022

I need this feature to write tests for methods used in chain subcommand.

If this PR is rejected, I will still need it. I will put it somewhere like test.utils in that case.


It is unclear at all whether this feature is needed by our users. We should first discuss with the users, and with our PO (@tesnimab), whether this is needed.

It is targeted for CI capabilities.

I can imagine lots of situations when it won't work at all:

The implementation is rushed, and I suppose there are cases where it will work not as expected

It is not the exclusive way to set up chain binary. atomkraft chain remote is an alternative to atomkraft chain binary.

if the project is compiled not using make build (e.g. some custom build process)
if there are multiple executables produced

I agree with this. But this works for most cosmos-sdk chain binary.

e.g. , I am not particularly fond of including things like glob("/") into our codebase. It may have many unforeseen consequences

Did you mean a long runtime to loop glob("*/*")? Notice, I only search for files till depth 2.

@andrey-kuprianov andrey-kuprianov changed the title Compile chain binary from remote [WIP] Compile chain binary from remote Aug 30, 2022
@rnbguy rnbguy changed the title [WIP] Compile chain binary from remote feat: compile chain binary from remote Nov 11, 2022
@rnbguy rnbguy marked this pull request as draft November 11, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile remote chain repository via CLI
2 participants