Cherry pick PRs #11784, #11757 into release 1.20 bp #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sorts the security groups of the port model and when querying the cloud, which will result in tasks comparing those slices deterministically.
This fixes the rendering of the Corefile of the NodeLocal DNSCache template when setting forwardToKubeDNS to false (or not setting it). Previously, due to not dereferencing the bool pointer, the Corefile was always rendered with the true clause, due to checking the address instead of the actual value of the variable. With this fix, the templating mechanism will actually respect the value of forwardToKubeDNS and render it accordingly.
This enables to use config drives instead of the metadata service as a source for the user data (cloudinit).
ederst
changed the title
mguggi
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks changes of kubernetes#11757 and kubernetes#11784 into our release branch (release-1.20-bp).