-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy URL of focus #571
Conversation
This works on list-based pages such as "All", "Videos", "News", etc. It doesn't work for the "Image" page.
Thanks, looks great overall, did you try to test it (see README for how to)? |
src/options.js
Outdated
@@ -152,6 +152,7 @@ const DEFAULT_KEYBINDINGS = { | |||
showImagesLarge: ['z l'], | |||
showImagesMedium: ['z e'], | |||
showImagesIcon: ['z i'], | |||
copyUrlKey: ['c', 'y'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the default value for the keybinding?
Going forward, I want to avoid adding new default keybindings. You can still configure it for yourself in the settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Do you mean |
Yes, either that or using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. (I wish the authors of the Google styleguide explained the rational behind the rule to put four spaces. I haven't seen that one before in other styleguides.) |
This works on list-based pages such as "All", "Videos", "News", etc.
It doesn't work for the "Image" page.
See also: #549 #570