Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy URL of focus #571

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat: copy URL of focus #571

merged 3 commits into from
Nov 6, 2023

Conversation

mikez
Copy link
Contributor

@mikez mikez commented Nov 4, 2023

This works on list-based pages such as "All", "Videos", "News", etc.
It doesn't work for the "Image" page.

See also: #549 #570

This works on list-based pages such as "All", "Videos", "News", etc.
It doesn't work for the "Image" page.
@infokiller
Copy link
Owner

Thanks, looks great overall, did you try to test it (see README for how to)?

src/options.js Outdated
@@ -152,6 +152,7 @@ const DEFAULT_KEYBINDINGS = {
showImagesLarge: ['z l'],
showImagesMedium: ['z e'],
showImagesIcon: ['z i'],
copyUrlKey: ['c', 'y'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the default value for the keybinding?
Going forward, I want to avoid adding new default keybindings. You can still configure it for yourself in the settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@mikez
Copy link
Contributor Author

mikez commented Nov 5, 2023

Thanks, looks great overall, did you try to test it (see README for how to)?

Do you mean yarn install && yarn build --env production && ./tools/make-firefox.sh?
I installed the add-on from the zip file and it seemed to work.

@infokiller
Copy link
Owner

Thanks, looks great overall, did you try to test it (see README for how to)?

Do you mean yarn install && yarn build --env production && ./tools/make-firefox.sh? I installed the add-on from the zip file and it seemed to work.

Yes, either that or using web-ext (see https://github.com/infokiller/web-search-navigator#building-for-development)

Copy link
Owner

@infokiller infokiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikez
Copy link
Contributor Author

mikez commented Nov 6, 2023

Lint fails (https://github.com/infokiller/web-search-navigator/actions/runs/6761539284), please follow https://github.com/infokiller/web-search-navigator#coding-style

Done.

(I wish the authors of the Google styleguide explained the rational behind the rule to put four spaces. I haven't seen that one before in other styleguides.)

@infokiller infokiller merged commit 9222337 into infokiller:master Nov 6, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants