[Bug Report] Up/Down shortcuts are broken when Google continuously loads new results

[MahdiNazemi]

Google may be testing a new feature that loads new results as you get to the end of the page (instead of having results on separate pages).

I suspect WSN modifies the page on load and, therefore, does not support the newly shown results.

[infokiller]

I can't reproduce this, any specific queries where you see this behavior?

[MahdiNazemi]

All my queries show the same behavior. I just Googled "google search results" and saw more results loading as I scrolled down. Would a video recording or copy of the HTML/CSS help?

…

On Thu, Dec 15, 2022 at 2:42 AM infokiller ***@***.***> wrote: I can't reproduce this, any specific queries where you see this behavior? — Reply to this email directly, view it on GitHub <#464 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWBAPLTNJACWJC55RAVUTLWNLY2NANCNFSM6AAAAAAS7FLVEM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[infokiller]

Thanks for offering, but I'm afraid I'd need a fully working page with JS to be able to fix this.

[infokiller]

I'm able to reproduce this when connected to a VPN server in Chicago

[MahdiNazemi]

It looks like this feature will be rolled out globally in the near future. There is a setting to disable this feature, but it does not have any effect in regions where continuous scrolling is available.

Can a MutationObserver detect such changes (similar to the example here) and apply WSN customizations to the newly displayed results?

[infokiller]

Thanks @MahdiNazemi I think I fixed this on master, can you please clone the repo and run it in dev mode (see #464) to verify if it works for you?

[MahdiNazemi]

Thank you, @infokiller. I installed the dev version according to the instructions in README.

The extension works well most of the time. There are a few corner cases where I see issues, and I don't know whether they are because of the extension or Google's new search experience.

• Sometimes, Google does not load new results when I get to the bottom of the page, and WSN selects the "More results" button. Pressing Enter on the selected "More results" button loads a new page similar to the old search experience. If instead of pressing Enter, I go up a few results with WSN by holding K such that "More results" goes out of the viewport and come back down by pressing J, I see the results loaded continuously.

[infokiller]

@MahdiNazemi this is similar to #389 (comment)
Just to confirm, when you navigate to the "more results" button using the extension, does it work?
If so, I consider this issue fixed, and a separate issue can be opened for implementing the params mentioned by the comment above.

[MahdiNazemi]

@infokiller, the extension can select "More results", but when I press Enter, it does not load more results in the same page. Instead, it loads a new page in the old Google search experience (Page 2). I can then use WSN's shortcuts like H and L keys to go to Page 1 or Page 3.

I am not sure if this should be addressed in this issue or a new issue. Please let me know how to proceed.

[infokiller]

@MahdiNazemi sorry, I accidentally linked to an unrelated issue in my previous comment- I meant to link to this one: #389 (comment)

I opened #494 to track the new issue
What I meant to say is that I think this issue can be considered fixed because even though you may not always get full navigation in continuous mode, it still enables you to navigate to all the results.
I will close this issue when a new version with the patch is deployed in Chrome and Firefox, and you can follow #494 for the change that is required to fix the inconvenience you described.

[MahdiNazemi]

• Sometimes, Google does not load new results when I get to the bottom of the page, and WSN selects the "More results" button. Pressing Enter on the selected "More results" button loads a new page similar to the old search experience. If instead of pressing Enter, I go up a few results with WSN by holding K such that "More results" goes out of the viewport and come back down by pressing J, I see the results loaded continuously.

I just learned that if I press Space on "More Results" instead of Enter, Google will load more results on the same page.

[infokiller]

Thanks for the update @MahdiNazemi
I will keep the issue open till I release the new version

[eggbean]

This continuous scrolling has been enabled for me now in the UK and I hate it. I have Continuous scroll disabled in https://www.google.com/preferences#tabVal=1, but I can't get rid of it. Nothing that can be done?