Correcting parsing error since using : in Key

[infograf768]

We have new strings in com_admin.ini for 4.0.4 containing :
Image after patch

This works fine as : is authorized for parsing inis in general but creates errors in com_localise as : is not taken care of when parsing.
This PR adds the : in the translation model as well as in parseini.js

Before patch:

After patch

@Valc
This one is urgent

[Valc]

@infograf768
HEre is working fine. I think the new changes are under control with your patch.

[infograf768]

Thanks for testing. Don't forget to update your branches. ;)

[Valc]

@infograf768
Due the issue now will crash the translation access on previour com_localise releases, i think we need a new com_localise release, please.

And, what about automaric updates? seems is not ready to get automatic alert about the new versions released from here.

[infograf768]

Making new pack now.
I hesitate to create an updateserver which would be placed in my repo as, normally, when we are ready to release, this should go to the original github repo which is a Joomla Project.

[infograf768]

here is the new pack
https://github.com/infograf768/j4localise/releases/download/5.0.0-beta5/com_localise-5.0.0-beta5.zip

[Valc]

@infograf768
At line 1993 of "LocaliseHelper.php" on "combineReferences" function also present the issue:

if (preg_match('/^([A-Z][A-Z0-9_\*\-\.]*)\s*=/', $line, $matches))

As changed with your patch should be:

if (preg_match('/^([A-Z][A-Z0-9_:\*\-\.]*)\s*=/', $line, $matches))

[Valc]

Making new pack now. I hesitate to create an updateserver which would be placed in my repo as, normally, when we are ready to release, this should go to the original github repo which is a Joomla Project.

Thanks, JM.

I have also seen that you have offered it where it corresponds, with no response at the moment.

joomla-projects/com_localise#340 (comment)

[infograf768]

@Valc
#33 (comment)

I can correct directly but it looks like the combineReferences method used only in the TranslationModel to get $this->item->source is useless.

[Valc]

I can correct directly but it looks like the combineReferences method used only in the TranslationModel to get $this->item->source is useless.

It certainly seems that this is used just to have that information in the item but in the end it is not used anywhere.

Anyway and since it is there, I think it does not hurt to fix it. Maybe in the future is required call that information from somewhere and the bug would already be solved.

If i am not wrong that info bypassed by that function was useful to create the translation language files with the right en-GB set of keys and strings (due maybe there was develop or not, or due we was using the local en-GB installed instance as reference or not).

But in this moment the struff creating the translation file based on the en-GB reference is working fine without to call "combineReferences"

If the bug is present, i suggest to solve it :)

[infograf768]

Corrected.