node attribues should be 'normal', not 'override' -- they don't show up as printed on the node otherwise #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up as printed on the node otherwise
|
Only the immutable things changed levels; the other two lines appear to just be formatting change. Pulled into the 3.2.0 branch. |
|
Oh hey, lookit that! How retroactively smart and thoughtful past me was, to make that normal not override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ironfan syncs the node to the server, it should set the node attributes using 'nornal', not 'override'.
Please note: though I believe this is the correct behavior I don't know whether currently-existing nodes will have a remnant 'override' attribute. All but one of attributes in question are immutable on a node -- organization, cluster_name, facet_name and facet_index -- but
permanentis not.