-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aliases #388
Merged
Merged
Aliases #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JkhatriInfobox
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for aliases on Host Record LGTM
JkhatriInfobox
added a commit
that referenced
this pull request
Oct 30, 2024
* Added support for ZoneDelegated object (#379) --------- Co-authored-by: Neil Garratt <[email protected]> Co-authored-by: Piper Dougherty <[email protected]> * Next available (#387) * Implement next_available network support for NW and NW conatiner * adding next_available_ip support for RecordAAAA and RecordHost in terraform * adding support for next-available-ip for hostrecord and record:aaaa * adding aliases field on host record (#388) * A record implementation for next available ip (#385) * Test cases for a record next-available-ip (#391) * test cases for a record and aaaa record * test cases for aaaa record - next_available_ip * validation if aliases have domain name suffix if dns is enabled and test cases for alias field (#392) * test cases for a record and aaaa record * test cases for aaaa record - next_available_ip * validation if aliases have domain name suffix if dns is enabled and test cases for alias field * aliases for ip association * Fix for NPA-193 (#393) * adding other fields for host-record (#394) * adding other fields for host-record * change next-available-ip function in recordA * Host record after rebasing * bugFix for hostRecord ip_addr_type and disable fields (#396) * Fix for NPA-195 (#395) * Fix for NPA-193 * Fix for NPA-195--->Added a function to handle leading zeros for IPV6 * handling leading zeros for cidr in network container * Update resource_infoblox_ip_allocation.go Added missing braces for statfunc * NPA-199: fix- updating error message and ip_association_test file (#397) * Npa 201 (#399) * NPA-199: fix- updating error message and ip_association_test file * NPA-201 fix: setting CIDR value while dynamic allocation of NW, NWC and updating documentation for filter_params fields and error msg for alias format * removing disable field from AAAA record * alias field added in datasource file (#400) modified the test cases for host record DiffSuppressFunc added to handle the plan difference between configuration file and state file * test cases for host record and network container for next available IP (#398) * test cases for host record and network container for next available IP * revert the changes for cidr and added IPV6 test case for network container * Fix for NPA-155 --> TypeSet in the schema for delegate_to field changed to TypeList (#402) * NPA-205 fix: adding network_view in object_parameters map (#401) * NPA-207 fix: adding disable field for host record datasource (#403) * Fix for NPA-208 (#404) * NPA-209 Fix: removing ipv4_addr and ipv6_addr fields from statefile for dynamic allocation using filter_params (#405) * DiffSupress function changes for alias field in host record when dns is disabled (#406) * DiffSupress function changes for alias field in host record when dns is disabled * Updating ttl value : ttl value being de-referenced in the assoication when its nil * Npa 200 fix: Deleting aliases field when DNS is enabled (#408) * updating documentation and adding examples for next-available and zone-delegated * NPA-200 fix: deleting aliases when dns is enabled * NPA-211 Fix: adding IPV4 as default value for ip_address_type (#409) * formatting examples for next-available and zone-delegated (#410) * not setting ip_address_type and object fields when filter_params is not used (#413) * setting ip_addr_type, object fields to null during import and disable fields. (#414) * setting ip_addr_type, object fields to null during import and disable field during import and read * adding error check for d.set * updating docs folder and ReadME for zone-delegated and next-available (#412) * updating docs folder and ReadME for zone-delegated and next-available * updating review comments for documentation * removing default values for data source example * Updated vendor directory (#416) * correction for the typo in error message for A record (#411) --------- Co-authored-by: Aish-sp <[email protected]> Co-authored-by: Neil Garratt <[email protected]> Co-authored-by: Piper Dougherty <[email protected]> Co-authored-by: Chaithra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding aliases field on host record