Add option to ignore license check

[jpereira]

That fix is necessary to use with Infoblox instances running in-house.

[alibasim86]

Hi Everyone, Can we get this pull request merged pls, beside any test instances issues the same core code can work with infoblox that does not have cloud license installed

[saiprasannasastry]

Hi This has not been merged because they want the cloud licence check to be a integral part of terraform.I will get back on this ASAP

[dvob]

Why is the license check requreid? In my opinion the license check should be removed entirely. The only thing the client (terraform-provider) does is using the WAPI, but the WAPI can also be used without the CNA licenese.

[saiprasannasastry]

i've told our PM to look at the comments on goclient as well regarding the same. i will talk to him and get an update

[jpereira]

Well, as usual. the PM being as a PM.

[saiprasannasastry]

still waiting on his response

[saiprasannasastry]

@jpereira Pm told to remove the cloud license check all together. quick question ,The value of LICENSE_NOCHECK passed should be a string?

[jpereira]

yes

[dvob]

In my opinion it would make more sense to remove the license check entirely, then we don't need the LICENSE_NOCHECK option. See my proposal in #36
Or are there cases when the license check is required?

[saiprasannasastry]

Will remove it.

[saiprasannasastry]

closing this PR as we have decided to remove license check