Added generic function for search by alt id. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…don't go for EA Search and always search with Ref and get back second search only works if NotFound by ref and InternalID is present.
- Added more records - Reduced multiple map lookups.
…ontainer, DNS View).
… with the provided internal id.
…d object with the given internal id.
…nternal id is missing.
| } else if strings.TrimSpace(internalId) == "" { | ||
| // return object if internal id is empty | ||
| success = true | ||
| return success, nil |
There was a problem hiding this comment.
why it is returned true here
There was a problem hiding this comment.
We should return the return response received when fetched by ref and the internal id is empty. I should have updated the comment to return true if response is not nil and internal id is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.