Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove omitempty json tag from dns/dhcp struct #221

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove omitempty json tag from dns/dhcp struct #221

merged 1 commit into from
Feb 23, 2024

Conversation

akshay8
Copy link
Contributor

@akshay8 akshay8 commented Feb 23, 2024

  • Remove omitempty json tag from DNS and DHCP struct
  • As in request build method, json marshal will remove zero values of the field. But EnableDns/EnableDhcp is required in the body.

hemanthKa677
hemanthKa677 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@hemanthKa677 hemanthKa677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemanthKa677 hemanthKa677 merged commit fe8efc1 into infobloxopen:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemanthKa677 hemanthKa677 hemanthKa677 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshay8 @hemanthKa677