Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce request builder with headers #218

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Introduce request builder with headers #218

merged 3 commits into from
Jan 11, 2024

Conversation

smalisetti-infoblox
Copy link
Contributor

@smalisetti-infoblox smalisetti-infoblox commented Jan 10, 2024 •
edited
Loading

the new type can be used like the following

header := make(http.Header)
header.Add("x", "1")
header.Add("y", "2")

wrb, _ := NewWapiRequestBuilder(hostCfg, authCfg)
wrbh, err := NewWapiRequestBuilderWithHeaders(wrb, header)

@smalisetti-infoblox smalisetti-infoblox changed the title Introduce new request builder with headers Introduce request builder with headers Jan 10, 2024
hemanthKa677
hemanthKa677 reviewed Jan 10, 2024
View reviewed changes
connector_test.go Outdated

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)

func TestHeaderRequestBuilder_BuildRequest(t *testing.T) {
header := make(http.Header)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add as Describe function similar to other Describe functions?

hemanthKa677
hemanthKa677 reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@hemanthKa677 hemanthKa677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case is working fine. Looks good for me.

@hemanthKa677 hemanthKa677 merged commit 4632604 into infobloxopen:master Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnagaraj80 pnagaraj80 pnagaraj80 approved these changes

@hemanthKa677 hemanthKa677 Awaiting requested review from hemanthKa677

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smalisetti-infoblox @pnagaraj80 @hemanthKa677