Adds condition for 'name' parameter in A record for uppercase letters #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudriavtsev
requested changes
Jun 7, 2023
object_manager_a-record.go
Outdated
| @@ -82,6 +86,10 @@ func (objMgr *ObjectManager) UpdateARecord( | |||
| "'name' argument is expected to be non-empty and it must NOT contain leading/trailing spaces") | |||
| } | |||
|
|
|||
| if name != strings.ToLower(name) { | |||
There was a problem hiding this comment.
remove strings.ToLower from line #83
object_manager_a-record_test.go
Outdated
| objMgr = NewObjectManager(conn, cmpType, tenantID) | ||
|
|
||
| _, err = objMgr.UpdateARecord(initRef, newDnsName, ipAddr, "", "", ttl, useTtl, "some comment", nil) | ||
| Expect(err).ToNot(BeNil()) |
There was a problem hiding this comment.
Please, check against a specific error message text. Besides, could you please add a test case about leading and trailing spaces?
skudriavtsev
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds the condition for A Record, if any uppercase letters exists in the 'name' parameter value. As NIOS internally converts the uppercase letters to lower case, hence to maintain consistency with NIOS and plugin, this changes are being made.