fix to be able to remove aliases with module nios_host_record #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sent this same PR to
community.generalcollection and the maintainers asked me to also send it to this repoThis fix allows to remove aliases from host objects using module
nios_host_record. All the details are in ansible-collections/community.general#1335As I am not familiar with the nios modules and
nios_modules/plugins/module_utils/api.pyis used by many other modules I tried that this PR only affects the use case I tested. That's why I useif key == 'aliases'. I verified that that there is no other nios module using an argument namedaliasesso I think this fix should only apply for the use case I tried to fix. Let me know if you know of a better approach to fix the bug