Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTEUDO-2095: DB role claim username should be optional #366

Merged
merged 1 commit into from
Nov 26, 2024
Merged

PTEUDO-2095: DB role claim username should be optional #366

merged 1 commit into from
Nov 26, 2024

Conversation

bfabricio
Copy link
Contributor

@bfabricio bfabricio commented Nov 22, 2024 •
edited
Loading 

The DbRoleClaim CR expects the status.username  field to be set. 
However, some older version of the db-controller does not handle setting the status.username. 
To address this, we should make the DbRoleClaimStatus.username field optional.

@bfabricio bfabricio merged commit afdf6b5 into main Nov 26, 2024
3 checks passed
@bfabricio bfabricio deleted the PTEUDO-2095 branch November 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewwells drewwells drewwells approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfabricio @drewwells