Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json_query not sending token in request #128

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Fix json_query not sending token in request #128

merged 2 commits into from
Sep 8, 2023

Conversation

bytedream
Copy link
Contributor

Description

This PR fixes the issue that the Client::json_query function doesn't send the Authorization HTTP header (#126)

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo doc2readme -p influxdb --expand-macros
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@Empty2k12
Copy link
Collaborator

Thanks a lot!

Could you add a test which covers this case, so it never breaks again?

@bytedream
Copy link
Contributor Author

Sure, I've added two tests testing if the auth is working correctly.

Copy link
Collaborator

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@msrd0 msrd0 merged commit 065c201 into influxdb-rs:main Sep 8, 2023
@Empty2k12
Copy link
Collaborator

Thanks a lot!

@bytedream bytedream deleted the fix-json-query-auth-error branch September 8, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants