-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HTTP basic auth for webhooks #9332
Conversation
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for something so relevant to many plugins, I'd like to see it have its own folder for auth
in the common folder, and I'd like to see support for more auth types in addition to Basic, specifically api key and maybe bearer token.
Should I be adding API key and bearer token auth along with this PR, or should it be a separate issue? |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Hey @akrantz01! hope you are well - any interest in resolving conflicts and landing this still? Thanks! |
Co-authored-by: Sebastian Spaink <[email protected]>
6416f26
to
f1d8977
Compare
Sure! All the merge conflicts should be resolved now |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Co-authored-by: Sebastian Spaink <[email protected]>
Required for all PRs:
resolves #6023
Adds support for HTTP basic auth in webhooks where each webhook type to have a different username and password.