Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP basic auth for webhooks #9332

Merged
merged 7 commits into from
Mar 4, 2022

Conversation

akrantz01
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #6023

Adds support for HTTP basic auth in webhooks where each webhook type to have a different username and password.

@akrantz01 akrantz01 added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/webhook labels Jun 4, 2021
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for something so relevant to many plugins, I'd like to see it have its own folder for auth in the common folder, and I'd like to see support for more auth types in addition to Basic, specifically api key and maybe bearer token.

plugins/inputs/webhooks/common/basic_auth.go Outdated Show resolved Hide resolved
plugins/inputs/webhooks/common/basic_auth_test.go Outdated Show resolved Hide resolved
@akrantz01
Copy link
Contributor Author

Should I be adding API key and bearer token auth along with this PR, or should it be a separate issue?

@akrantz01 akrantz01 changed the title HTTP basic auth for webhooks feat: HTTP basic auth for webhooks Aug 26, 2021
plugins/common/auth/basic_auth.go Outdated Show resolved Hide resolved
@srebhan srebhan requested a review from sspaink October 12, 2021 12:48
@powersj
Copy link
Contributor

powersj commented Mar 3, 2022

Hey @akrantz01! hope you are well - any interest in resolving conflicts and landing this still? Thanks!

@akrantz01
Copy link
Contributor Author

Sure! All the merge conflicts should be resolved now

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 4, 2022

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 4, 2022
@sspaink sspaink merged commit f76729c into influxdata:master Mar 4, 2022
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for basic auth for Webhooks input plugin
4 participants