Migrate from github.com/ericchiang/k8s to github.com/kubernetes/client-go

[sspaink]

The Kubernetes client project ericchiang/k8s has been archived since 2019, looks like kubernetes/client-go is the replacement. Migrated the plugin kube_inventory and Prometheus to use the new client.

[telegraf-tiger]

🤝 ✅ CLA has been signed. Thank you!

[ivorybilled]

Nice, makes some of the code cleaner too

[varunjain0606]

@sspaink I am observing some issue related to the changes in this line and related logic.

telegraf/plugins/inputs/kube_inventory/node.go

Line 31 in 1872037

fields["capacity_cpu_cores"] = convertQuantity(string(val.Format), 1)

I am getting a string(val.Format) value as either "DecimalSI" or "BinarySI" and hence getting error while parsing these values.
Logs from parser:

2021-08-03T03:37:20Z D! [inputs.kube_inventory] failed to parse quantity: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'
2021-08-03T03:37:20Z D! [inputs.kube_inventory] failed to parse quantity: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'
2021-08-03T03:37:20Z D! [inputs.kube_inventory] failed to parse quantity: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'
2021-08-03T03:37:20Z D! [inputs.kube_inventory] failed to parse quantity: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'

Once I convert string(val.Format) to val.String(), things seem to work fine. May I know why format is used as input to
convertQuantity() function? Is it supposed to be like that? If yes then what could be the issue.

Similar bug has been raised already.
#9535

[sspaink]

@varunjain0606 Thank you for reporting this issue, looks like using format was a mistake. I noticed your pr #9581 to fix this, thank you for resolving it so quickly!

[varunjain0606]

@sspaink No problem. Glad to help. Cheers!

[gracewehner]

Hi @sspaink I found an issue related to the change in the watchPod() function in the file inputs/prometheus/kubernetes.go. I have created an issue #9600 and PR #9605 to address this.