Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard tags json parser support #8579

Merged
merged 10 commits into from
Dec 18, 2020
Merged

Add wildcard tags json parser support #8579

merged 10 commits into from
Dec 18, 2020

Conversation

helenosheaa
Copy link
Member

Closes #7531

@helenosheaa helenosheaa requested a review from ssoroka December 16, 2020 20:47
srebhan
srebhan reviewed Dec 16, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
srebhan
srebhan requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor (whitespace) comments in the code. However, the test can be simplified using a table approach defining the config and the expected outcome and then do the logic only once in a for loop over that table.

@srebhan srebhan self-assigned this Dec 16, 2020
@srebhan
Copy link
Member

srebhan commented Dec 17, 2020

@helenosheaa the fixes look good, can you please also address the comment in the test-file!?

helenosheaa
helenosheaa commented Dec 17, 2020
View reviewed changes
Copy link
Member Author

@helenosheaa helenosheaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan yes that's the test file changed now as well, thanks for the review :)

@sjwang90 sjwang90 added area/json json and json_v2 parser/serialiser related feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 17, 2020
@helenosheaa helenosheaa merged commit 94eb8f2 into master Dec 18, 2020
@helenosheaa helenosheaa deleted the Add-wildcard-tags-json-parser-support branch December 18, 2020 00:32
srebhan
srebhan reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes!

ssoroka pushed a commit that referenced this pull request Dec 18, 2020
@helenosheaa @ssoroka
Add wildcard tags json parser support (#8579)
cb0d55b 
(cherry picked from commit 94eb8f2)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@helenosheaa
Add wildcard tags json parser support (influxdata#8579)
ce1a27f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan requested changes

@ssoroka ssoroka ssoroka approved these changes

Assignees

@srebhan srebhan

Labels
area/json json and json_v2 parser/serialiser related feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Json Parser wildcard tagkey support
4 participants
@helenosheaa @srebhan @ssoroka @sjwang90