Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show how to return a custom error with the Starlark processor #8439

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Show how to return a custom error with the Starlark processor #8439

merged 2 commits into from
Nov 20, 2020

Conversation

essobedo
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Fix for #8403

Motivation

It seems to be unclear for end-users to return a custom error with the Starlark processor

Modifications

  • Adds a new Starlark script to show how to return a custom error thanks to the function fail
  • Adds the corresponding unit test that proves that it works as expected
  • Refers the new Starlark script from the README.md

@essobedo essobedo mentioned this pull request Nov 19, 2020
Closed
srebhan
srebhan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@srebhan srebhan self-assigned this Nov 20, 2020
@ssoroka ssoroka merged commit bbd4e80 into influxdata:master Nov 20, 2020
@essobedo essobedo deleted the 8403/custom_error branch November 21, 2020 10:35
ssoroka pushed a commit that referenced this pull request Dec 1, 2020
@essobedo @ssoroka
Show how to return a custom error with the Starlark processor (#8439)
f35ba79 
(cherry picked from commit bbd4e80)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@essobedo
Show how to return a custom error with the Starlark processor (influx…
a64e426 
…data#8439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@ssoroka ssoroka ssoroka approved these changes

Assignees

@srebhan srebhan

Labels
area/starlark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@essobedo @ssoroka @srebhan @sjwang90