Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tags for monitoring readable secondaries for Azure SQL MI #8369

Merged
merged 9 commits into from
Dec 8, 2020
Merged

Added tags for monitoring readable secondaries for Azure SQL MI #8369

merged 9 commits into from
Dec 8, 2020

Conversation

bhsu-ms
Copy link
Contributor

@bhsu-ms bhsu-ms commented Nov 5, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Added new column - is_primary_replica in DB queries for monitoring readable secondaries.
@denzilribeiro Could you please review this PR for exposing replica role to monitor readable secondaries for MI?

denzilribeiro
denzilribeiro suggested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@denzilribeiro denzilribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity can we actually have the tag as 'READ_ONLY' or READ_WRITE just return the property itself rather than returning a 0/1?
Aka
DATABASEPROPERTYEX(DB_NAME(), 'Updateability') as replica_updateability

denzilribeiro
denzilribeiro approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@denzilribeiro denzilribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed MI related changes

@denzilribeiro denzilribeiro mentioned this pull request Nov 23, 2020
Closed
3 tasks
@bhsu-ms
Copy link
Contributor Author

bhsu-ms commented Dec 3, 2020

@ssoroka / @reimda could you help merging this PR? Thanks!

@bhsu-ms
Copy link
Contributor Author

bhsu-ms commented Dec 7, 2020

@ssoroka Could you help approving this PR? Thanks!

@ssoroka ssoroka merged commit 752a4b7 into influxdata:master Dec 8, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@bhsu-ms
Added tags for monitoring readable secondaries for Azure SQL MI (infl…
bbc0f93 
…uxdata#8369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denzilribeiro denzilribeiro denzilribeiro approved these changes

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
area/sqlserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhsu-ms @ssoroka @denzilribeiro @sjwang90