SQL Server - PerformanceCounters - removed synthetic counters #8325
Conversation
| ,@Columns AS nvarchar(MAX) = ' | ||
| ,@PivotColumns AS nvarchar(MAX) = ' |
There was a problem hiding this comment.
You are right, I replaced some single quotes and that introduced that error, as it should be 2 single-quotes.
Anyway turns out those variables are no longer needed and can be removed, as there were only used in the shythetic counters section.
Thanks for spotting it.
There was a problem hiding this comment.
I already made a commit to remove the variables
|
When we had a look at the code (me and @denzilribeiro), we had no idea about what those counters were doing there, so we concluded they were there in the first version of the plugin, to compensate for something (maybe specific) that was missing. But since they just don't belong to SQL Server performance counters, It's probably better to remove, they might cause confusion as you can't find them in the SQL server dmv (sys.dm_os_performance_counters), also the "Workload Group" related counters are already there, in the default counters here is part of the conversation |
(cherry picked from commit 1313f23)
Required for all PRs:
This PR removes some synthetic performance counters from the sqlserver_performance_counters measurement.
We believe that those counters were added to create unavailable counters on older editions of SQL Server, as of now, some of those counters already exist even in SQL 2008. In any case, we don't really want to fetch performance counters that do not exist.